Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(link): added legal link #2569

Merged
merged 1 commit into from
Feb 18, 2025
Merged

feat(link): added legal link #2569

merged 1 commit into from
Feb 18, 2025

Conversation

agliga
Copy link
Contributor

@agliga agliga commented Feb 12, 2025 •
edited
Loading

Fixes #2564

  • This PR contains CSS changes
  • This PR does not contain CSS changes

Description

  • Added new legal link token
  • Added new legal-link class to links
  • Updated links to use link tokens (which were not being used or in the code)

Screenshots

Screenshot 2025-02-12 at 10 46 29 AM

Checklist

  • I verify the build is in a non-broken state
  • I verify all changes are within scope of the linked issue
  • I regenerated all CSS files under dist folder
  • I tested the UI in all supported browsers
  • I did a visual regression check of the components impacted by doing a Percy build and approved the build
  • I tested the UI in dark mode and RTL mode
  • I added/updated/removed Storybook coverage as appropriate

@agliga agliga self-assigned this Feb 12, 2025
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Feb 12, 2025

🦋 Changeset detected

Latest commit: 6c251b5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@ebay/skin Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

ArtBlue
ArtBlue approved these changes Feb 18, 2025
View reviewed changes
Copy link
Contributor

@ArtBlue ArtBlue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@ArtBlue ArtBlue merged commit 2acf205 into 19.1.0 Feb 18, 2025
@ArtBlue ArtBlue deleted the link-legal branch February 18, 2025 21:52
This was referenced Feb 12, 2025
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArtBlue ArtBlue ArtBlue approved these changes

@HenriqueLimas HenriqueLimas Awaiting requested review from HenriqueLimas

@saiponnada saiponnada Awaiting requested review from saiponnada

@LuLaValva LuLaValva Awaiting requested review from LuLaValva

Assignees

@agliga agliga

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@agliga @ArtBlue